Skip to content

London | 26-ITP-January | Divine Mankrado | Sprint 1 | Wireframe#1076

Open
divinmank wants to merge 14 commits intoCodeYourFuture:mainfrom
divinmank:feature/wireframe
Open

London | 26-ITP-January | Divine Mankrado | Sprint 1 | Wireframe#1076
divinmank wants to merge 14 commits intoCodeYourFuture:mainfrom
divinmank:feature/wireframe

Conversation

@divinmank
Copy link

@divinmank divinmank commented Jan 26, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have designed my own wireframe.

@netlify
Copy link

netlify bot commented Jan 26, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 25124e7
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6985da9bf652b40008741583
😎 Deploy Preview https://deploy-preview-1076--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 90 (🟢 up 4 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@divinmank divinmank added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 26, 2026
@divinmank divinmank mentioned this pull request Jan 30, 2026
Open
cjyuan
cjyuan reviewed Feb 3, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you:

    • Center the "PAGE TITLE" and the "SHORT DESCRIPTION" beneath it
    • Center the footer content
      ?

  • When there are a lot of text in the articles, or when the page is zoomed in to 200+%, the footer and the articles could overlap, making the footer content almost "unreadable". Can you address this issue?

Everything else look good.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 3, 2026
@divinmank divinmank mentioned this pull request Feb 5, 2026
Open
@divinmank divinmank added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 5, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 5, 2026
@github-actions

This comment has been minimized.

Sign in to view
@divinmank divinmank added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 5, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 5, 2026

  • One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask ChatGPT what that requirement means).

  • Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

    • Reply to their feedback.
      • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
        • You may find the suggestions in this PR Guide useful.
      • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
    • Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
      • Without this label, the reviewer would not know if your changes is ready to be reviewed.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 5, 2026
@divinmank
I added position: fixed, bottom: 0, and width: 100% to the footer sty…
25124e7 
…les, and added bottom padding to the body to prevent the footer from overlapping the main content.
@divinmank
Copy link
Author

divinmank commented Feb 6, 2026

I added position: fixed, bottom: 0, and width: 100% to the footer styles, and added bottom padding to the body to prevent the footer from overlapping the main content.

@divinmank divinmank added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 6, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 6, 2026

Changes look good. Well done.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 6, 2026
@divinmank divinmank mentioned this pull request Feb 7, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@divinmank @cjyuan